github: update goveralls tool#9348
Merged
guggero merged 1 commit intolightningnetwork:masterfrom Dec 12, 2024
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ziggie1984
force-pushed
the
update-goveralls
branch
from
dbe17ef to
eaadfac
Compare
ziggie1984
force-pushed
the
update-goveralls
branch
2 times, most recently
from
97c8bcd to
07a1bc0
Compare
ellemouton
approved these changes
Dec 12, 2024
Collaborator
ellemouton
left a comment
ellemouton
left a comment
There was a problem hiding this comment.
lgtm! Perhaps a good idea to link to the PR you are referencing in the commit message?
The goverall tool had a bug regarding the module versioning of golang packages see also mattn/goveralls#222 for more background. Goveralls is wrapped by another library to make it available for github actions. So the relevant PR which is referenced here in LND is: shogo82148/actions-goveralls#521.
ziggie1984
force-pushed
the
update-goveralls
branch
from
07a1bc0 to
c6bdbbe
Compare
Collaborator
Author
|
Added the relevant PRs, thanks all for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update goveralls tools to support golang module versioning.
The goverall tool had a bug regarding the module versioning of
golang packages see also
mattn/goveralls#222 for more background.
Goveralls is wrapped by another library to make it available for
github actions. So the relevant PR which is referenced here in
LND is:
shogo82148/actions-goveralls#521.